[Form] List Symfony UX form types #16377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/ Cheers! Carsonbot |
wouterj
force-pushed
the
symfony-ux-form-types
branch
from
508d542 to
f29a641
Compare
|
Oh my, we already stopped support for 5.2 😅 Thanks Carson! |
wouterj
changed the title
wouterj
changed the title
and 5.3 soon to be as well ^^ |
94noni
approved these changes
Jan 8, 2022
|
Totally in favor of listing these form types. My only question is about organization, especially future-proof organization. Do we want to mix UX types with regular types ... or do we group all UX types in a dedicated section to add some text and link explaining that they need Symfony UX, etc. ? |
wouterj
force-pushed
the
symfony-ux-form-types
branch
from
f29a641 to
0f820de
Compare
|
@javiereguiluz I've moved them to their own little section |
OskarStark
approved these changes
Jan 18, 2022
|
Thanks Wouter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimately, I think the Symfony UX docs should be completely moved to this repo. But I'm not sure what exactly the plans/ideas are for this.
Let's start by just advertising Symfony UX in the official docs :)
cc @tgalopin @weaverryan